milon / barcode

Laravel Barcode Generator
Other
1.32k stars 318 forks source link

Bugs in your Datamatrix class that are fixed in TCPDF #88

Open neilcrookes opened 4 years ago

neilcrookes commented 4 years ago

There's been a 6 commits (bug fixes etc) since 2013 to the datamatrix class in TCPDF e.g. https://github.com/tecnickcom/TCPDF/commit/c36a5bc4fb0f3459b3ce3c6c2a08ca6cda46edbd that don't appear to be in your version of this file.

Are you able to apply them please? It should just be a case of copying the code from their repo.

neilcrookes commented 4 years ago

These are the missing fixes:...

6.2.2 (2014-12-18) nicolaasuni committed on 18 Dec 2014

6.0.077 (2014-05-06)

6.0.076 (2014-05-06)

6.0.069 (2014-04-24)

6.0.068 (2014-04-22)

6.0.052 (2013-12-12)

neilcrookes commented 4 years ago

@milon thanks for your recent updates on this package today. Have you had chance to look at this issue?

It looks to me like the code you copied from tcpdf, when you copied it, was already out of date by a few years, but it's complicated by the fact that the header lines in your version are the same as the headers lines from the latest file in tcpdf. But if you compare the actual code in the file, they are quite different.

I think if you resolve this, you'll fix #86, #87 and this issue.

neilcrookes commented 4 years ago

It might also solve #96