search

milos-agathon / make-your-3d-city

In this repo, I will show you how to use LiDAR and orthophoto data to create a stunning 3D city map using rayshader in R
6 stars 1 forks source link

Not rendering as expected #2

Closed lbarqueira closed 11 months ago

lbarqueira commented 1 year ago

Hi Milos,

thank you for sharing the code.

While reproducing your code as-is, I obtained at Point 6 (Render) the following (snapshot):

milos_issue_github

I have reproduced your code exactly as it is.

I can not understand the reason for the black portion of the image.

Notice also, than the image (png) that is saved in 4. SAVE ORTHO AS IMAGE, is as following:

binnenhof

Could you please help me identify this issue?

Thank you very much,

Luis Barqueira

milos-agathon commented 12 months ago

Hi Luis, thanks for sharing this issue with me. I think this has to do with the latest version of rayshader that you're using. Could you downgrade your rayshader to the previous version?

lbarqueira commented 12 months ago

Hi Milos, after downgrading rayshader the issue remains.

I have solved this issue with the following workaround: baseshape = "circle" in plot_3d.

milos-agathon commented 12 months ago

Thank you, Luis! If you open the pull request with your changes (including the downgrade part), I'll merge it into my main branch.

lbarqueira commented 12 months ago

Hi Milos, I am using rstudio and I am not connected to github,. I have to follow your tutorial on using Vscode with R, because I feel more comfortable to use vscode to connect to github. As soon as I change from IDE, I will create a pull request with the changes. Thank you Luis