miloschuman / yii2-highcharts

Highcharts widget for Yii 2 Framework
http://www.yiiframework.com/extension/yii2-highcharts-widget/
MIT License
166 stars 63 forks source link

Fix temporarily suppress notice on PHP82 #93

Closed Myks92 closed 1 year ago

Myks92 commented 1 year ago

@miloschuman, Function jsonSerialize() must be mixed type on PHP82.

Full error:

During inheritance of JsonSerializable: Uncaught yii\base\ErrorException: Return type of miloschuman\highcharts\SeriesDataHelper::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to

acorncom commented 1 year ago

@miloschuman I'm not seeing the above fix released on Packagist yet, am I missing something? Happy to fork and handle that on our end if that's better

miloschuman commented 1 year ago

@acorncom Sorry about that. It is released now in v10.0.

acorncom commented 1 year ago

@miloschuman no problem at all, appreciate it!

sevlad commented 7 months ago

With php8.3 problem is actual again. miloschuman/yii2-highcharts-widget/src/SeriesDataHelper.php:150 Fix please: public function jsonSerialize() -> public function jsonSerialize(): mixed