search

milosgajdos / servpeek

Introspective peek into your server guts
30 stars 3 forks source link

Fixes a bug when multiple versions of a package are installed #11

Closed milosgajdos closed 8 years ago

milosgajdos commented 8 years ago

Previously when you had multiple version of a same package installed servpeek would fail to parse query command output (thanks gem). This should be fixed now. The fix brings an interesting benefit: if you're not interested in the version of a package when querying it, you can simply ignore the last argument of NewSwPkg function. This PR also hides Cmd fields to avoid situations when external package clients mess around with them during command execution.

agonzalezro commented 8 years ago

Except the naming conventions, the rest looks good. Feel free to merge it if you don't agree with the naming questions.

agonzalezro commented 8 years ago

LGTM

Kindly reminder that you need to add CircleCI! :D