search

milosjanda / react-scroll-up

React component to add custom buttons for scrolling to top of page
MIT License
175 stars 28 forks source link

Typescript support #34

Closed dacevedo12 closed 4 years ago

dacevedo12 commented 5 years ago

any plans? I'd like to contribute but I first need to know the maintainer opinion on which of the following options seems more appropriate

a. Provide the types to this repo (index.d.ts file). b. Provide the types through https://github.com/DefinitelyTyped c. Consider rewriting this package in TS since the codebase is small

milosjanda commented 5 years ago

No plans for now, but this is very nice idea and i am open to accept pull requests. I prefer a. Provide the types to this repo (index.d.ts file)., because it is easy to maintenaince,

Esot3riA commented 4 years ago

Hello.

I'd want to use this library with Typescript, but it didn't seems to support Typescript. So I writed simple declaration file (index.d.ts).

Can I add a pull request to support Typescript syntax?

Thank you. Esot3riA

milosjanda commented 4 years ago

Hello, Of course, I would be grateful for a pull request. Thanks.