Adding onShow and onHide props

milosjanda / react-scroll-up

React component to add custom buttons for scrolling to top of page

MIT License

175 stars 28 forks source link

Closed Nadav42 closed 4 years ago

Nadav42 commented 4 years ago

Hello, I need support for onShow and onHide props to prevent having to add extra redundant scroll listeners checking the same thing.

will you accept a pull request for this? or add it yourself?

Nadav42 commented 4 years ago

@milosjanda

milosjanda commented 4 years ago

Hi, good point, pull request is welcome ;)

Nadav42 commented 4 years ago

Hi, good point, pull request is welcome ;)

done in pull request #37

milosjanda commented 4 years ago

Nice work, thanks for contribution.