With React 18, type error as children are not listed as props

[Codigo-Fuentes]

Error is fixed my just adding children prop to interface ScrollToTopProps

[Codigo-Fuentes]

Fix

[jeffdrumgod]

Correct implement until fix component:

import type { ScrollToTopProps as ScrollToTopPropsCustom } from 'react-scroll-up';

declare module 'react-scroll-up' {
  export interface ScrollToTopProps extends ScrollToTopPropsCustom {
    children?: React.ReactNode;
  }
}

[therealgilles]

I'm getting this error with the above temp fix:

Type 'ScrollToTopProps' recursively references itself as a base type.

[rgmvisser]

@therealgilles It worked for me when adding https://github.com/milosjanda/react-scroll-up/issues/43#issuecomment-1250182332 into a separate .d.ts file. Hope that helps!

[milosjanda]

Please send the pull request, because I can't simulate it and everything works for me as is.

[rgmvisser]

@milosjanda https://github.com/milosjanda/react-scroll-up/pull/45

[milosjanda]

Sorry i missed it. It`s merged and new version has been released. Could you please confirm that everything work fine?

[rgmvisser]

Confirmed, thanks!

[milosjanda]

Thank you.