milosmns / actual-number-picker

Android: A horizontal number picker
GNU General Public License v3.0
222 stars 36 forks source link

not any bug or something but i want my slow key to add or subtract 0.1 and fast key to add or subtract 1 #18

Open Vishal0311 opened 3 years ago

Vishal0311 commented 3 years ago

As your slow arrow move with speed of 1 i want it to move with speed of 0.1 and fast arrow with speed of 1.

how can i change this.

milosmns commented 3 years ago

Hey, not sure I understand.

Can you give an example?

milosmns commented 3 years ago

I think I get it.

It's actually not fixed 0.1 or 1: https://github.com/milosmns/actual-number-picker/blob/master/picker/src/main/java/me/angrybyte/numberpicker/view/ActualNumberPicker.java#L601

So if you want to change it, it would require complicated code changes at this point. I'm swamped with other work so I don't have time to do it unfortunately... but I'll be happy to review your contribution if you want to fork and make the change yourself.

Vishal0311 commented 3 years ago

Happy to see your reply.. I'm working on it....

On Sun, 18 Apr 2021 at 15:31, Milos Marinkovic @.***> wrote:

I think I get it.

It's actually not fixed 0.1 or 1: https://github.com/milosmns/actual-number-picker/blob/master/picker/src/main/java/me/angrybyte/numberpicker/view/ActualNumberPicker.java#L601

So if you want to change it, it would require complicated code changes at this point. I'm swamped with other work so I don't have time to do it unfortunately... but I'll be happy to review your contribution if you want to fork and make the change yourself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/milosmns/actual-number-picker/issues/18#issuecomment-821966572, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFHPXCEQ375G2UNTYEAZE3TJKUYDANCNFSM43DHTCBQ .

Vishal0311 commented 3 years ago

so I forked and sent a pull request , kindly look at it.

On Sun, 18 Apr 2021 at 16:39, Vishal Kumar @.***> wrote:

Happy to see your reply.. I'm working on it....

On Sun, 18 Apr 2021 at 15:31, Milos Marinkovic @.***> wrote:

I think I get it.

It's actually not fixed 0.1 or 1: https://github.com/milosmns/actual-number-picker/blob/master/picker/src/main/java/me/angrybyte/numberpicker/view/ActualNumberPicker.java#L601

So if you want to change it, it would require complicated code changes at this point. I'm swamped with other work so I don't have time to do it unfortunately... but I'll be happy to review your contribution if you want to fork and make the change yourself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/milosmns/actual-number-picker/issues/18#issuecomment-821966572, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFHPXCEQ375G2UNTYEAZE3TJKUYDANCNFSM43DHTCBQ .

milosmns commented 3 years ago

I left a comment there. I just realized that distribution might be an issue here as I'd need to do some structural changes that touch CI/CD pipelines and change authentication... this could take a lot of time.

Maybe it's just easier to clone & include this project into your project? Or just copy/paste this View and it's attributes XML? I'm ok with that too, don't worry about the license 🙂

That way you can make any changes you want without me constraining you

Vishal0311 commented 3 years ago

Thanks, I'll check it out.

On Sun, 18 Apr 2021 at 18:28, Milos Marinkovic @.***> wrote:

I left a comment there. I just realized that distribution might be an issue here as I'd need to do some structural changes that touch CI/CD pipelines and change authentication... this could take a lot of time.

Maybe it's just easier to clone & include this project into your project? Or just copy/paste this View and it's attributes XML? I'm ok with that too, don't worry about the license 🙂

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/milosmns/actual-number-picker/issues/18#issuecomment-821987961, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFHPXFKEVJWRXWMBY5AV7LTJLJQXANCNFSM43DHTCBQ .