search

milosmns / actual-number-picker

Android: A horizontal number picker
GNU General Public License v3.0
222 stars 36 forks source link

Touching the view should not fire valueChange event but only dragging #5

Open ahmadalibaloch opened 7 years ago

ahmadalibaloch commented 7 years ago

If I just touch the view at for example half, it will set the value to 50 or (which is half). The correct behavior for this half visible (moving cycle) as visible from the display is, to change value on its movement or dragging.

No matter where I touch, it should change the value according to the dragging distance,only when I drag. Even If I touch near end and move to half, and say I dragged for value 20, it should change the existing 50 value to 30. 50-20 = 30.

milosmns commented 7 years ago

This is something I planned for a future release. Maybe you could fork the repository and improve the functionality? I'm more than happy to review the pull request and merge here. I'm sort of swamped with other projects so I have little time to address these issues right away.

ahmadalibaloch commented 7 years ago

I will create pull requests, for some problems, over the weekend.

prazjain commented 7 years ago

@milosmns @ahmadalibaloch Any updates on this one? I expected this to be default behaviour, so value changed is fired only when drag has finished.

milosmns commented 7 years ago

I was busy with other things (still am), but you're invited to fork and do it :)