search

miloszzieba / coronatrace-ios

1 stars 1 forks source link

Issue #1: Fetching GPS location #13

Closed leszko11 closed 4 years ago

leszko11 commented 4 years ago

Closes #1

pmieszal commented 4 years ago

@leszko11

  1. How about separate location workers?

    • LocationSignificantChangesWorker - mainly for background tracking, stored in AppDelegate.
    • LocationUpdatesWorker - for most accurate tracking when app is in foreground.

  2. How this PR solves fetch user location as often & precise as it possible in background modes? I see that this worker is not initialized anywhere also.

  3. We talk about triggering location fetch on background fetch - this is also missing.

leszko11 commented 4 years ago

@pmieszal

  1. How about separate location workers?
  • LocationSignificantChangesWorker - mainly for background tracking, stored in AppDelegate.
  • LocationUpdatesWorker - for most accurate tracking when app is in foreground.
  1. How this PR solves fetch user location as often & precise as it possible in background modes? I see that this worker is not initialized anywhere also.
  2. We talk about triggering location fetch on background fetch - this is also missing.

  1. Maybe we can observe foreground/background notifications, and switch tracking options inside LocationManager?

  2. But it's ready to use 😎

  3. I'm not really sure how you want to perform it? How about splitting it to separate issues?

pmieszal commented 4 years ago

@pmieszal

  1. How about separate location workers?
  • LocationSignificantChangesWorker - mainly for background tracking, stored in AppDelegate.
  • LocationUpdatesWorker - for most accurate tracking when app is in foreground.
  1. How this PR solves fetch user location as often & precise as it possible in background modes? I see that this worker is not initialized anywhere also.
  2. We talk about triggering location fetch on background fetch - this is also missing.
  1. Maybe we can observe foreground/background notifications, and switch tracking options inside LocationManager?
  2. But it's ready to use 😎
  3. I'm not really sure how you want to perform it? How about splitting it to separate issues?

Damnit, there is no option to comment on comment? 😢

  1. https://developer.apple.com/documentation/uikit/app_and_environment/scenes/preparing_your_ui_to_run_in_the_background/updating_your_app_with_background_app_refresh