search

milouse / flycheck-grammalecte

Fork of flycheck-grammalecte to support Grammalecte v0.6.4+ (Mirror)
https://git.umaneti.net/flycheck-grammalecte/about/
GNU General Public License v3.0
10 stars 3 forks source link

CRISCO new URL #24

Closed arsaber101 closed 1 year ago

arsaber101 commented 1 year ago

CRISCO has a new url (without redirection...) : https://crisco4.unicaen.fr/des/synonymes/synonyme

milouse commented 1 year ago

Thank you for the notification. I just fix it quickly. I wonder if it worth moving the CRISCO URL in a variable to allow one to change it?

arsaber101 commented 1 year ago

Maybe. Or a warning in return that the connexion failed. For now it just returns Aucun synonyme Aucun antonyme,, which is not true.

It is not the first time CRISCO changes its URL. That's why I suspected a failure to connect. Before I came across your package (Thanks for it by the way) I used for years a couple of shell scripts I wrote (badly, I am not a programmer at all) from within emacs. They returned me a w3m-dump, roughly formatted throught pipe, of my requests. Because I encountered problems of failure with CRISCO, I changed the synonyme-script to point to CNRTL Synonymie instead. Datas are the same (CRISCO is the provider of CNRTL), but CNRTL proves to be far more reliable. It could be another solution, but would implies a complete rewriting of the functions grammalecte-find-synonyms and grammalecte-find-synonyms-at-point, and the writing of two others functions for Antonymes, as they are not at the same URL as Synonymes in CNRTL site...

Thank again for your work, by far more elegant than what I was able to scribble.

While I am here, I open a Feature Request for a really cosmetic (but annoying) point…