miloxeon
commented
1 year ago Hi @tumispro! Thanks for the feedback. Glad you liked it!
Not incorporating pinch-to-zoom and similar patterns was a conscious decision. Every browser, desktop and mobile, has its own way to zoom on the web. If I mimic them, it will result in double zoom: my plugin will zoom in the picture while the browser is zooming in on the whole page. I've seen that in other plugins, and I didn't like it. For example, as of today, this happens in Slack's picture viewer.
If I invent my own gestures/shortcuts, users won't be familiar with them and won't know how to zoom.
The only way is to disable browser's default zoom in behaviour in favour of my plugin's. This will break the accessibility.
Bottom line is, this plugin is designed to fit organically and doesn't try to take over the control. The browser default zoom in/zoom out actions work with the plugin perfectly. While the picture is zoomed in, you can zoom in even further by zooming in the page itself.
The only scenario it doesn't work with is for the websites where developers disabled page zoom with a viewport meta tag. This is a bad accessibility practice, and it's not in the scope of this plugin to fix it.
tumispro
The plugin is really excellent. As the zoom feels like a mobile phone photoviewer, would it perhaps be possible to allow further zooming in/out using pinch gestures on a trackpad or mobile device, or perhaps ctrl/command + scroll on a desktop?