search

miloyip / nativejson-benchmark

C/C++ JSON parser/generator benchmark
MIT License
1.98k stars 261 forks source link

Fix build with gcc 8.3.0. #123

Open mity opened 4 years ago

mity commented 4 years ago

This fixes https://github.com/miloyip/nativejson-benchmark/issues/102#issue-304171553 (the issue in the 1st post there.)

mloskot commented 4 years ago

This still does not make the whole thing build and run successfully, does it?

mity commented 4 years ago

This still does not make the whole thing build and run successfully, does it?

No, it does not.

To make it build and run on my Linux machine, I also had to disable about 10 parser implementations which either did not build or which were crashing the tests.

I didn't want to mix that with this PR because maybe they do work on some other platform(s) and disabling them is not really a fix.

mloskot commented 4 years ago

This still does not make the whole thing build and run successfully, does it?

No, it does not.

OK. I was double-checking what's the status of the repo.

To make it build and run on my Linux machine, I also had to disable about 10 parser implementations which either did not build or which were crashing the tests.

Yup, I confirm it's needed (as per detailed in comments to #102).

Thanks.

mity commented 4 years ago

If you find it useful, https://github.com/mity/nativejson-benchmark (master) now contains all the fixes (and addition of Centijson) I needed to make it work on my machine.

Don't be fooled though: I use it now for checking my JSON implementation but I have no intention to maintain the benchmark in the long term.

mloskot commented 4 years ago

@mity Thanks. I did similar and have fixed branch in my fork :) Not to be maintained in long term either.