search

miloyip / nativejson-benchmark

C/C++ JSON parser/generator benchmark
MIT License
1.95k stars 262 forks source link

Minor fixes #132

Closed lemire closed 4 years ago

lemire commented 4 years ago

The current code probably does not count properly and it is unnecessarily complicated at times. (These are very minor fixes that should not change the results very much.)

lemire commented 4 years ago

cc @Mark407 @jkeiser

jkeiser commented 4 years ago

Um. @Mark407 I shouldn't be approving PRs, sorry--thought this was in the simdjson repo :)

lemire commented 4 years ago

@jkeiser I am glad you reviewed the code.

I think that the current code will not count INT64 and UINT64 values as numbers.

You also surely noticed that it had too much code for turning a document back into a string.

Neither of these things are very important. Tiny things.