miltador / angular-google-signin

Google Sign-In component for Angular written in TypeScript
BSD 3-Clause "New" or "Revised" License
21 stars 10 forks source link

ERROR in GoogleSignInComponent is not an NgModule #22

Open KoldBrewEd opened 7 years ago

KoldBrewEd commented 7 years ago

Is this still maintained?

Broken with Angular 4. You need to update the dependencies:

npm WARN angular-google-signin@0.1.5 requires a peer of @angular/core@^2.0.0 but none was installed. npm WARN angular-google-signin@0.1.5 requires a peer of rxjs@5.0.0-beta.12 but none was installed. npm WARN angular-google-signin@0.1.5 requires a peer of zone.js@^0.6.25 but none was installed.

miltador commented 7 years ago

Hi! I will put an eye on it in a few days. You are welcome to send me a PR in the meantime.

andrei-ivanov commented 7 years ago

+1 :-) Can't really help, I'm a newbie :-(

m47een commented 7 years ago

any update on a potential fix?

shah-smit commented 7 years ago

any updates on this?

tom10271 commented 7 years ago

I am not sure whether I have that peer dependencies error or not(but I guess I have it too), but the point is you need to declare it yourself then it will work. I am using Angular 4.3.3 and don't have any problem

miltador commented 6 years ago

Hi! I will look into it this weekend, bare with me!

MaciejWWojcik commented 6 years ago

any update?

PierreRoudaut commented 6 years ago

AOT build is still broken as well, any news/plans on that matter :) ?

andrei-ivanov commented 6 years ago

Maybe someone else with enough experience can fix this and send a PR? :-) And even check if it works on Angular 6? :-D