search

milux / ctldap

LDAP Wrapper for ChurchTools
GNU General Public License v3.0
12 stars 8 forks source link

SSL doesn't seem to work #41

Closed teleharry closed 1 year ago

teleharry commented 1 year ago

The options seems to be missing in const server = ldap.createServer(); So, ldaps doesn't work, even ldapCertFilename and ldapKeyFilename ist defined.

Could you change it for future release?

if (config.ldapCertFilename && config.ldapKeyFilename) {
  const ldapCert = fs.readFileSync(new URL(`./${config.ldapCertFilename}`, import.meta.url), { encoding: "utf8" }),
      ldapKey = fs.readFileSync(new URL(`./${config.ldapKeyFilename}`, import.meta.url), { encoding: "utf8" });
  options = { certificate: ldapCert, key: ldapKey };
}
const server = ldap.createServer(options);
milux commented 1 year ago

If you already have fixed that, could you provide us a PR please? :)

milux commented 1 year ago

Fixed in version 3.1.0.