search

milux / ctldap

LDAP Wrapper for ChurchTools
GNU General Public License v3.0
12 stars 8 forks source link

ext match implementation missing #42

Open miltechniks opened 1 year ago

miltechniks commented 1 year ago

First of all thanks for your work.

I tried to attach a gitlab-Server to the LDAP-Wrapper, but there seems to be a missing implementation accordings to the log: missing-implementation.txt As Reference also this Pull-Request, which is obsolet with your changes as it doesn't help anymore with version 3.0.1: https://github.com/churchtools/ctldap-ms/pull/4 As there is the new version, I created here the Issue.

So today I tested it with the version 3.0.1 (commit 94aeab97bd2763d50a471d18b0abc7ecaf8d4a9c) and it wasn't successfull. When I add

ldap.ExtensibleFilter.super_.prototype.matches = function() {
}

it's working, but I'm pretty shure there is some implementation for that function missing. ;-)

milux commented 1 year ago

Seems like GitLab is using some sort of unknown special filter, indicated by its OID 1.2.840.113556.1.4.803. According to https://oidref.com/1.2.840.113556.1.4.803, this is a special bitwise matcher. Your "patch" is obviously not doing anything of that kind, and is also overwriting matches for all instances created from ldap.ExtensibleFilter.super_'s prototype. Properly fixing PR welcome. :wink: