milux / ctldap

LDAP Wrapper for ChurchTools
GNU General Public License v3.0
12 stars 8 forks source link

Add Directory Information and Docker build #9

Closed sscholl closed 6 years ago

sscholl commented 6 years ago

add Search implementation for basic search for Directory Information Tree and the LDAP Root DSE (was required by zammad help desk)

milux commented 6 years ago

Looks nice. Why were most of the files moved to the /app subfolder? Can you please explain the specific reason for this?

sscholl commented 6 years ago

Because i copy the content of app to the Dockerfile. I can change this if you want. Then also the content of the root folder is inside the Dockerfile, which is not a problem. Then I would create another PR.

milux commented 6 years ago

By "Dockerfile", do you mean the docker image you're creating? I consider this strategy with the separate folder a bit unclean... afaik it's best practice to use a .dockerignore file, see here: https://stackoverflow.com/questions/43747776/copy-with-docker-but-with-exclusion

2 further questions:

sscholl commented 6 years ago

Hey milux, i reworked it now. I think, all your point are done. You can set up https://cloud.docker.com to build the image. Maybe change the image names as well in the docker-compose file. I attached the configuration. image Best Regards, Simon