milvus-io / birdwatcher

Apache License 2.0
46 stars 33 forks source link

Keep tailing slash for kv operations #214

Closed congqixia closed 12 months ago

congqixia commented 12 months ago

Since path.Join will remove tailing slash, the newly added kv implementation will return some other kv values when prefix need this tailing slash.

Add a util function to keep this tailing slash and replace all path.Join in kv impl with it

Fix #213

sre-ci-robot commented 12 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/birdwatcher/blob/main/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment