search

milvus-io / birdwatcher

Apache License 2.0
43 stars 32 forks source link

allow deletion of non-exist key #220

Closed yiwangdr closed 9 months ago

yiwangdr commented 10 months ago

We should allow deletions of non-exist keys, which is the behavior of old versions of birdwatcher. Let's keep the behavior consistent.

xiaofan-luan commented 10 months ago

/lgtm /approve

sre-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaofan-luan, yiwangdr To complete the pull request process, please assign congqixia after the PR has been reviewed. You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/birdwatcher/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment