fix: Fix panicking in `remove collection-drop` when collection not exist

milvus-io / birdwatcher

Apache License 2.0

43 stars 32 forks source link

fix: Fix panicking in `remove collection-drop` when collection not exist #250

Closed congqixia closed 6 months ago

congqixia commented 6 months ago

When collection with provided id not exist, birdwatcher will have NPE panic

Also add log and return fast when list collection fails in same command

sre-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/birdwatcher/blob/v1.0.x/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

aoiasd commented 6 months ago

/lgtm