search

milvus-io / birdwatcher

Apache License 2.0
46 stars 33 forks source link

fix: [1.0.x] Add WithBlock option when connecting Etcd #253

Closed congqixia closed 6 months ago

congqixia commented 6 months ago

Use with block dial option when create etcd client so that dry connect may detect bad etcd address as well.

XuanYang-cn commented 6 months ago

/lgtm /approve

sre-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/birdwatcher/blob/v1.0.x/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment