enhance: Refine history suggestion when input contains spaces

milvus-io / birdwatcher

Apache License 2.0

43 stars 32 forks source link

enhance: Refine history suggestion when input contains spaces #262

Closed congqixia closed 4 months ago

congqixia commented 4 months ago

For history suggestion mode, suggestion item will be appended after last space, which may cause incorrect input for multi-word commands, say:

show collections after suggetions became show show collections

This PR make suggestion item trim parts before last space.

sre-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/birdwatcher/blob/v1.0.x/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

weiliu1031 commented 4 months ago

/lgtm