search

milvus-io / birdwatcher

Apache License 2.0
43 stars 32 forks source link

enhance: Add setup workspace step to enable history by default #263

Closed congqixia closed 4 months ago

congqixia commented 4 months ago

Birdwatcher shall put history log in workspace folder. If the folder does not exist, history logging will fail. This PR make birdwatcher to try to create folder by default and try it best to enable history logging

XuanYang-cn commented 4 months ago

/lgtm /approve

sre-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/birdwatcher/blob/v1.0.x/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment