milvus-io / birdwatcher

Apache License 2.0
46 stars 33 forks source link

enhance: Add auto detect rootPath for connect command #271

Closed congqixia closed 5 months ago

congqixia commented 5 months ago

Find instance rootPath is painful, this PR add auto flag to find milvus rootPath in etcd. If there is only one candidate, connect command will use it automatically

sre-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/birdwatcher/blob/v1.0.x/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
weiliu1031 commented 5 months ago

/lgtm