search

milvus-io / knowhere

Knowhere is an open-source vector search engine, integrating FAISS, HNSW, etc.
Apache License 2.0
205 stars 83 forks source link

Threadpool based HNSW insert #989

Open fhaltmayer opened 1 year ago

fhaltmayer commented 1 year ago

Update the Add() of HNSW to use thread pool instead of using its own omp.

sre-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fhaltmayer To complete the pull request process, please assign liliu-z after the PR has been reviewed. You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/knowhere/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sre-ci-robot commented 1 year ago

Welcome @fhaltmayer! It looks like this is your first PR to milvus-io/knowhere 🎉

mergify[bot] commented 1 year ago

@fhaltmayer Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

fhaltmayer commented 1 year ago

https://github.com/milvus-io/knowhere/issues/514

liliu-z commented 1 year ago

/assign @cqy123456

liliu-z commented 1 year ago

/kind improvement

cqy123456 commented 1 year ago

/lgtm

cqy123456 commented 1 year ago

@fhaltmayer Can you compare the hnsw indexing time before and after using the thread pool?