search

milvus-io / milvus-docs

This repository is for Milvus technical documentation update and maintenance. Visit Milvus.io for fully rendered technical documents.
Apache License 2.0
67 stars 265 forks source link

[ERROR]: Minor Issue with Langchain Integration Docs #2569

Closed devesh-2002 closed 1 day ago

devesh-2002 commented 1 month ago

Is there an existing issue for this?

Issue

From the docs, Integration with langchain. I was trying to install via the docs : 

! python -m pip install --upgrade pymilvus langchain langchain-core langchain-community langchain-openai langchain_text_splitters openai tiktoken

but it gave error

ModuleNotFoundError: No module named 'bs4'

Also, the second issue, we have imported ChatPromptTemplate, while used PromptTemplate, so it gave an error.

NameError: name 'PromptTemplate' is not defined

Should I rectify these errors in the docs?

Suggestion

For the first issue I had to install bs4. For second issue I changed : 

from langchain_core.prompts import ChatPromptTemplate

to

from langchain_core.prompts import PromptTemplate

Anything else?

No response

liyun95 commented 6 days ago

/assign @zc277584121 can you help troubleshoot this issue? thanks in advance!

zc277584121 commented 1 day ago

@devesh-2002 Thank you for your suggestion. We have updated this document and these issues have currently been solved. image image