search

milvus-io / milvus-sdk-cpp

C++ SDK for Milvus 2.0
Apache License 2.0
38 stars 21 forks source link

Refine some types related headers #170

Closed matrixji closed 2 years ago

matrixji commented 2 years ago

Related Issue: #168

Signed-off-by: Ji Bin matrixji@live.com

sre-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matrixji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-sdk-cpp/blob/master/OWNERS)~~ [matrixji] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
matrixji commented 2 years ago

/cc @yhmo /cc @ArkaprabhaChakraborty

codecov[bot] commented 2 years ago

Codecov Report

Merging #170 (8d2cde9) into master (91abd2f) will increase coverage by 0.10%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   99.15%   99.26%   +0.10%     
==========================================
  Files          39       44       +5     
  Lines        2238     2298      +60     
==========================================
+ Hits         2219     2281      +62     
+ Misses         19       17       -2
Impacted Files Coverage Δ
src/impl/TypeUtils.h 100.00% <ø> (ø)
src/include/milvus/Status.h 100.00% <ø> (ø)
src/include/milvus/types/CalcDistanceArguments.h 100.00% <ø> (ø)
src/include/milvus/types/CollectionInfo.h 100.00% <ø> (ø)
src/include/milvus/types/CollectionSchema.h 100.00% <ø> (ø)
src/include/milvus/types/CollectionStat.h 100.00% <ø> (+7.69%) :arrow_up:
src/include/milvus/types/CompactionPlan.h 100.00% <ø> (ø)
src/include/milvus/types/CompactionState.h 100.00% <ø> (ø)
src/include/milvus/types/DistanceArray.h 100.00% <ø> (ø)
src/include/milvus/types/FieldData.h 100.00% <ø> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91abd2f...8d2cde9. Read the comment docs.

ArkaprabhaChakraborty commented 2 years ago

/lgtm