search

milvus-io / milvus-sdk-cpp

C++ SDK for Milvus 2.0
Apache License 2.0
38 stars 21 forks source link

Bugfix, return error while connect to incorrect server. #187

Closed matrixji closed 2 years ago

matrixji commented 2 years ago

Signed-off-by: Ji Bin matrixji@live.com

sre-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matrixji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-sdk-cpp/blob/master/OWNERS)~~ [matrixji] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
matrixji commented 2 years ago

/uncc @fishpenguin /cc @ArkaprabhaChakraborty

codecov[bot] commented 2 years ago

Codecov Report

Merging #187 (68518fa) into master (2bc5483) will increase coverage by 0.08%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   99.30%   99.39%   +0.08%     
==========================================
  Files          47       47              
  Lines        2315     2321       +6     
==========================================
+ Hits         2299     2307       +8     
+ Misses         16       14       -2
Impacted Files Coverage Δ
src/impl/MilvusConnection.h 93.75% <ø> (ø)
src/impl/MilvusClientImpl.cpp 99.30% <100.00%> (ø)
src/impl/MilvusConnection.cpp 100.00% <100.00%> (+2.19%) :arrow_up:
src/impl/types/ConnectParam.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2bc5483...68518fa. Read the comment docs.

ArkaprabhaChakraborty commented 2 years ago

/lgtm