search

milvus-io / milvus-sdk-cpp

C++ SDK for Milvus 2.0
Apache License 2.0
38 stars 21 forks source link

Bugfix for ShowCollections #189

Closed matrixji closed 2 years ago

matrixji commented 2 years ago

fixes: #188

Signed-off-by: Ji Bin matrixji@live.com

sre-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matrixji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-sdk-cpp/blob/master/OWNERS)~~ [matrixji] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
matrixji commented 2 years ago

/cc @ArkaprabhaChakraborty /cc @Renekton

sre-ci-robot commented 2 years ago

@matrixji: GitHub didn't allow me to request PR reviews from the following users: Renekton.

Note that only milvus-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/milvus-io/milvus-sdk-cpp/pull/189#issuecomment-1139325837): >/cc @ArkaprabhaChakraborty >/cc @Renekton Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 2 years ago

Codecov Report

Merging #189 (37beeb4) into master (0d8b64f) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files          47       47           
  Lines        2321     2324    +3     
=======================================
+ Hits         2307     2310    +3     
  Misses         14       14
Impacted Files Coverage Δ
src/impl/MilvusClientImpl.cpp 99.30% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d8b64f...37beeb4. Read the comment docs.

ArkaprabhaChakraborty commented 2 years ago

/lgtm