search

milvus-io / milvus-sdk-cpp

C++ SDK for Milvus 2.0
Apache License 2.0
35 stars 21 forks source link

Promote proto to latest version. #192

Closed matrixji closed 2 years ago

matrixji commented 2 years ago

Fixes: #191

Signed-off-by: Ji Bin matrixji@live.com

sre-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matrixji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-sdk-cpp/blob/master/OWNERS)~~ [matrixji] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
matrixji commented 2 years ago

/cc @ArkaprabhaChakraborty /cc @yhmo

ArkaprabhaChakraborty commented 2 years ago

Ayee! Back to the old days :)...

ArkaprabhaChakraborty commented 2 years ago

/lgtm

codecov[bot] commented 2 years ago

Codecov Report

Merging #192 (96159a2) into master (3b5728c) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files          47       47           
  Lines        2327     2327           
=======================================
  Hits         2313     2313           
  Misses         14       14
Impacted Files Coverage Δ
src/impl/MilvusClientImpl.cpp 99.31% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more