milvus-io / milvus-sdk-cpp

C++ SDK for Milvus 2.0
Apache License 2.0
35 stars 21 forks source link

Support GetVersion #233

Closed matrixji closed 1 year ago

matrixji commented 1 year ago

Fixes: #220

Signed-off-by: Ji Bin matrixji@live.com

sre-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matrixji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-sdk-cpp/blob/master/OWNERS)~~ [matrixji] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 year ago

Codecov Report

Merging #233 (c65a769) into master (6c6f87c) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   97.39%   97.40%           
=======================================
  Files          34       34           
  Lines        2572     2581    +9     
=======================================
+ Hits         2505     2514    +9     
  Misses         67       67           
Impacted Files Coverage Δ
src/impl/MilvusClientImpl.h 100.00% <ø> (ø)
src/impl/MilvusConnection.h 100.00% <ø> (ø)
src/impl/MilvusClientImpl.cpp 94.77% <100.00%> (+0.04%) :arrow_up:
src/impl/MilvusConnection.cpp 99.23% <100.00%> (+0.01%) :arrow_up: