Open luisfmnunes opened 7 months ago
Welcome @luisfmnunes! It looks like this is your first PR to milvus-io/milvus-sdk-cpp 🎉
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
e90aa2f
) 97.33% compared to head (30ff077
) 97.19%.
/lgtm
/label ci-pass
@matrixji: The label(s) /label ci-pass
cannot be applied. These labels are supported: sdk/c++, sdk/go, sdk/http, sdk/java, sdk/python, severity/critical, severity/major, severity/minor, severity/moderate, test/accuracy, test/stability, test/ut, Summer 2021, WHY NOT
@luisfmnunes could you try to fix the clang-format issue with make clang-format
in the build directory? I could not directly merge your PR until you fix the format issue.
New changes are detected. LGTM label has been removed.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: luisfmnunes To complete the pull request process, please ask for approval from matrixji after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
@luisfmnunes could you try to fix the clang-format issue with
make clang-format
in the build directory? I could not directly merge your PR until you fix the format issue.
Sorry about that, seems like I messed up the identation somewhere and it was crashing clang build. I pushed a commit after running clang-format
/lgtm
@luisfmnunes sorry for handling this late, could you rebase your branch, then the codecov may pass, as I just update the codecov patch coverage target.
Added the GPU index types as metioned in Issue #257