search

milvus-io / milvus-sdk-cpp

C++ SDK for Milvus 2.0
Apache License 2.0
35 stars 21 forks source link

Added GPU IndexTypes to support Milvus-GPU #259

Open luisfmnunes opened 7 months ago

luisfmnunes commented 7 months ago

Added the GPU index types as metioned in Issue #257

sre-ci-robot commented 7 months ago

Welcome @luisfmnunes! It looks like this is your first PR to milvus-io/milvus-sdk-cpp 🎉

codecov[bot] commented 7 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e90aa2f) 97.33% compared to head (30ff077) 97.19%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus-sdk-cpp/pull/259/graphs/tree.svg?width=650&height=150&src=pr&token=sy9wGouk00&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus-sdk-cpp/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #259 +/- ## ========================================== - Coverage 97.33% 97.19% -0.15% ========================================== Files 34 34 Lines 2628 2637 +9 ========================================== + Hits 2558 2563 +5 - Misses 70 74 +4 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus-sdk-cpp/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [src/impl/types/IndexDesc.cpp](https://app.codecov.io/gh/milvus-io/milvus-sdk-cpp/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-c3JjL2ltcGwvdHlwZXMvSW5kZXhEZXNjLmNwcA==) | `98.88% <100.00%> (+0.01%)` | :arrow_up: | | [src/impl/TypeUtils.cpp](https://app.codecov.io/gh/milvus-io/milvus-sdk-cpp/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-c3JjL2ltcGwvVHlwZVV0aWxzLmNwcA==) | `97.80% <50.00%> (-0.61%)` | :arrow_down: |
matrixji commented 7 months ago

/lgtm

matrixji commented 7 months ago

/label ci-pass

sre-ci-robot commented 7 months ago

@matrixji: The label(s) /label ci-pass cannot be applied. These labels are supported: sdk/c++, sdk/go, sdk/http, sdk/java, sdk/python, severity/critical, severity/major, severity/minor, severity/moderate, test/accuracy, test/stability, test/ut, Summer 2021, WHY NOT

In response to [this](https://github.com/milvus-io/milvus-sdk-cpp/pull/259#issuecomment-1935900100): >/label ci-pass Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
matrixji commented 6 months ago

@luisfmnunes could you try to fix the clang-format issue with make clang-format in the build directory? I could not directly merge your PR until you fix the format issue.

sre-ci-robot commented 6 months ago

New changes are detected. LGTM label has been removed.

sre-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: luisfmnunes To complete the pull request process, please ask for approval from matrixji after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/milvus-sdk-cpp/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
luisfmnunes commented 6 months ago

@luisfmnunes could you try to fix the clang-format issue with make clang-format in the build directory? I could not directly merge your PR until you fix the format issue.

Sorry about that, seems like I messed up the identation somewhere and it was crashing clang build. I pushed a commit after running clang-format

matrixji commented 6 months ago

/lgtm

matrixji commented 6 months ago

@luisfmnunes sorry for handling this late, could you rebase your branch, then the codecov may pass, as I just update the codecov patch coverage target.