search

milvus-io / milvus-sdk-cpp

C++ SDK for Milvus 2.0
Apache License 2.0
37 stars 21 forks source link

fix cmake in case of preinstalled grpc #267

Open nfrmtk opened 4 months ago

nfrmtk commented 4 months ago

Relates: #266 #255 After fixing error in #266 with grpc -> gRPC I got new error about gRPC not being able to find Protobuf, fixed by adding line 49 And then generation started failing, so I've changed this and this

sre-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nfrmtk To complete the pull request process, please assign yhmo after the PR has been reviewed. You can assign the PR to them by writing /assign @yhmo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/milvus-sdk-cpp/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sre-ci-robot commented 4 months ago

Welcome @nfrmtk! It looks like this is your first PR to milvus-io/milvus-sdk-cpp 🎉

nfrmtk commented 4 months ago

/assign @yhmo

nfrmtk commented 4 months ago

/assign @matrixji

matrixji commented 3 months ago

/lgtm