milvus-io / milvus-sdk-go

Go SDK for Milvus.
Apache License 2.0
347 stars 109 forks source link

fix: Return empty resultset for empty nq and related testcases #732

Closed ThreadDao closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 67.81609% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 71.98%. Comparing base (1c53c8f) to head (5b00816).

:exclamation: Current head 5b00816 differs from pull request most recent head 8514063. Consider uploading reports for the commit 8514063 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/732/graphs/tree.svg?width=650&height=150&src=pr&token=WJK43PV390&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/732?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #732 +/- ## ========================================== - Coverage 72.01% 71.98% -0.03% ========================================== Files 51 51 Lines 4742 4755 +13 ========================================== + Hits 3415 3423 +8 - Misses 1206 1209 +3 - Partials 121 123 +2 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/732?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [client/insert.go](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/732?src=pr&el=tree&filepath=client%2Finsert.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-Y2xpZW50L2luc2VydC5nbw==) | `78.47% <100.00%> (ø)` | | | [client/row.go](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/732?src=pr&el=tree&filepath=client%2Frow.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-Y2xpZW50L3Jvdy5nbw==) | `86.42% <100.00%> (ø)` | | | [entity/schema.go](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/732?src=pr&el=tree&filepath=entity%2Fschema.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-ZW50aXR5L3NjaGVtYS5nbw==) | `92.03% <100.00%> (+0.24%)` | :arrow_up: | | [client/data.go](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/732?src=pr&el=tree&filepath=client%2Fdata.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-Y2xpZW50L2RhdGEuZ28=) | `64.33% <71.42%> (+0.07%)` | :arrow_up: | | [entity/columns.go](https://app.codecov.io/gh/milvus-io/milvus-sdk-go/pull/732?src=pr&el=tree&filepath=entity%2Fcolumns.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-ZW50aXR5L2NvbHVtbnMuZ28=) | `46.31% <61.19%> (-0.36%)` | :arrow_down: |
congqixia commented 6 months ago

/kind bug

sre-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, ThreadDao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-sdk-go/blob/master/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment