milvus-io / milvus-sdk-go

Go SDK for Milvus.

Apache License 2.0

351 stars 110 forks source link

fix broken Grant() call #784

Closed nustiueudinastea closed 3 months ago

nustiueudinastea commented 4 months ago

The latest version of the SDK doesn't pass the actual privilege that is granted during a Grant() call. This causes the Grant call to fail in any situation.

This PR fixes this issue by extending the method signature to take a privilege parameter, similarly to how the Python SDK does. This was an easy fix because the protobuf structs already had the field in place, so the SDK only needs to use that correct field in the API call.

sre-ci-robot commented 4 months ago

Welcome @nustiueudinastea! It looks like this is your first PR to milvus-io/milvus-sdk-go 🎉

nustiueudinastea commented 4 months ago

/assign @congqixia

congqixia commented 3 months ago

@Mergifyio rebase

mergify[bot] commented 3 months ago

rebase

✅ Branch has been successfully rebased

congqixia commented 3 months ago

/kind bug

congqixia commented 3 months ago

/lgtm /approve

798 might have some conflict with this PR

@SimFG please fix after this patch merged

sre-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, nustiueudinastea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-sdk-go/blob/master/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment