milvus-io / milvus-sdk-java

Java SDK for Milvus.
https://milvus.io
Apache License 2.0
380 stars 153 forks source link

MetricType was not initialized in SearchIterator#executeNextSearch (#881), and cast errors occured in SearchIterator#checkRmRangeSearchParameters (#887) #883

Closed PiercarloSlavazza closed 4 months ago

PiercarloSlavazza commented 4 months ago

MetricType was not initialized in SearchIterator#executeNextSearch (#881)

sre-ci-robot commented 4 months ago

Welcome @PiercarloSlavazza! It looks like this is your first PR to milvus-io/milvus-sdk-java 🎉

PiercarloSlavazza commented 4 months ago

/assign @yelusion2

PiercarloSlavazza commented 4 months ago

This is a fix for #881 - sorry, this is my 1st PR and I have not been able to link to it

yhmo commented 4 months ago

@PiercarloSlavazza The DCO is not passed. It requires a mail address in the commit description. Could you modify your commit in this way:

  1. git commit --amend
  2. edit the commit description, add your github account and mail address like this:

    MetricType was not initialized in SearchIterator#executeNextSearch (#881)
    
    Signed-off-by: PiercarloSlavazza <your email address>
PiercarloSlavazza commented 4 months ago

@yhmo sign off added - I think we can merge now

PiercarloSlavazza commented 4 months ago

Added a fix for #887

PiercarloSlavazza commented 4 months ago

Removed fix for #887 because a patched has been already landed on master via commit ae9ba7b

yhmo commented 4 months ago

/lgtm /approve

sre-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PiercarloSlavazza, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-sdk-java/blob/2.4/OWNERS)~~ [yhmo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment