search

milvus-io / milvus-sdk-java

Java SDK for Milvus.
https://milvus.io
Apache License 2.0
380 stars 153 forks source link

Fix testcontainers dependency scope #991

Closed eddumelendez closed 1 month ago

eddumelendez commented 1 month ago

Testcontainers must have a test scope. Currently, it is a transitive dependency.

yhmo commented 1 month ago

/lgtm /approve

sre-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddumelendez, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-sdk-java/blob/2.3/OWNERS)~~ [yhmo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yhmo commented 1 month ago

@eddumelendez I just tried to cherry-pick your pr to master and 2.4 branch, but it failed. Could you cherry-pick this pr to master and 2.4 branch?

eddumelendez commented 1 month ago

@yhmo done! See #994 and #995