milvus-io / milvus-sdk-node

The Official Mivus node.js sdk(client)
https://milvus.io
Apache License 2.0
122 stars 37 forks source link

throw more errors if create collection failed with high level api #289

Closed shanghaikid closed 6 months ago

sre-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/milvus-sdk-node/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.58%. Comparing base (fd6640c) to head (26b750d).

Files Patch % Lines
milvus/MilvusClient.ts 80.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #289 +/- ## ========================================== - Coverage 96.61% 96.58% -0.04% ========================================== Files 36 36 Lines 1893 1901 +8 Branches 502 505 +3 ========================================== + Hits 1829 1836 +7 - Misses 56 57 +1 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.