search

milvus-io / milvus-sdk-node

The Official Mivus node.js sdk(client)
https://milvus.io
Apache License 2.0
122 stars 37 forks source link

rename loadCollectionSync => loadCollection #327

Closed shanghaikid closed 3 months ago

shanghaikid commented 3 months ago

this resolve #325

sre-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/milvus-sdk-node/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.72%. Comparing base (c9c07f7) to head (7690018).

Files Patch % Lines
milvus/grpc/Collection.ts 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #327 +/- ## ========================================== - Coverage 96.90% 96.72% -0.19% ========================================== Files 43 43 Lines 2651 2655 +4 Branches 652 653 +1 ========================================== - Hits 2569 2568 -1 - Misses 76 81 +5 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.