search

milvus-io / milvus-sdk-node

The Official Mivus node.js sdk(client)
https://milvus.io
Apache License 2.0
113 stars 35 forks source link

support passing certificate buffer #336

Closed shanghaikid closed 1 week ago

shanghaikid commented 1 week ago

relate #334

sre-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/milvus-sdk-node/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.62%. Comparing base (0db18b2) to head (bfbb62c).

Files Patch % Lines
milvus/grpc/BaseClient.ts 80.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #336 +/- ## ========================================== - Coverage 96.72% 96.62% -0.11% ========================================== Files 43 43 Lines 2655 2663 +8 Branches 653 661 +8 ========================================== + Hits 2568 2573 +5 - Misses 81 84 +3 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.