search

milvus-io / milvus-storage

Milvus file storage format repo
Apache License 2.0
17 stars 15 forks source link

use util and not internal #125

Closed mslacken closed 3 weeks ago

mslacken commented 1 month ago

fix complie failure as arrow::internal::Uri is a forward declaration

sre-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mslacken To complete the pull request process, please assign sunby after the PR has been reviewed. You can assign the PR to them by writing /assign @sunby in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/milvus-storage/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sre-ci-robot commented 1 month ago

Welcome @mslacken! It looks like this is your first PR to milvus-io/milvus-storage 🎉

shaoting-huang commented 1 month ago

I checked the namespace is arrow::internal::Uri. There is no arrow::util namespace

mslacken commented 1 month ago

Right, it needs to be arrow::internal::Uri, sorry for the typo. Should I update the PR?

shaoting-huang commented 3 weeks ago

Please update to the latest version, we have updated to arrow 17.0.0.