search

milvus-io / milvus-storage

Milvus file storage format repo
Apache License 2.0
17 stars 15 forks source link

fix: enable benchmark #151

Closed tedxu closed 21 hours ago

tedxu commented 1 day ago

Benchmark result:

------------------------------------------------------------------------
Benchmark                              Time             CPU   Iterations
------------------------------------------------------------------------
S3Fixture/Write32MB/real_time   43236907 ns     38985846 ns           13
S3Fixture/Read32MB/real_time     9751422 ns      8241057 ns           70

Write is much slower than read, not sure if it is expected.

sre-ci-robot commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-storage/blob/main/OWNERS)~~ [shaoting-huang,tedxu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shaoting-huang commented 21 hours ago

/lgtm