search

milvus-io / milvus-storage

Milvus file storage format repo
Apache License 2.0
19 stars 16 forks source link

[Cpp] Enable s3 fs #74

Closed sunby closed 1 year ago

sre-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-storage/blob/main/OWNERS)~~ [sunby] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sunby commented 1 year ago

/lgtm

sre-ci-robot commented 1 year ago

@sunby: you cannot LGTM your own PR.

In response to [this](https://github.com/milvus-io/milvus-storage/pull/74#issuecomment-1765754711): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yah01 commented 1 year ago

/lgtm