search

milvus-io / milvus-storage

Milvus file storage format repo
Apache License 2.0
19 stars 16 forks source link

Fix fs path mismatch in go and cpp #83

Closed jiaoew1991 closed 1 year ago

jiaoew1991 commented 1 year ago

The semantics of "path" are different in the fs interfaces of Go and C++. In C++, the path needs to include the bucket, while in Go version it is not required. This leads to issues with reading and writing.

sunby commented 1 year ago

/lgtm

sunby commented 1 year ago

/approve

sre-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus-storage/blob/main/OWNERS)~~ [sunby] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment