Failed to save if partition tag contains "/"

milvus-io / milvus-tools

A data migration tool for Milvus.

Apache License 2.0

69 stars 21 forks source link

Failed to save if partition tag contains "/" #10

Closed seo-jinBro closed 3 years ago

seo-jinBro commented 3 years ago

Hi, I'm using "/" to use a hierarchical structure in the partition, fails to save M2H.

In save_data.py, hdf5_filename and yaml_filename are just created by concatenating partition_tag.

I think "/" be escaped or os.makedir in save_hdf5_data (not in __init__)

shiyu22 commented 3 years ago

Hi, thanks for the issue, you are right and the code file you found is correct.

I think escaping the "/" would be a good idea, what do you think?

So can you submit a PR for this issue? I think it would be nice and you could be a Milvus-Tools contributor. Also, if you don't have time to contribute, please let me know your solution and we will fix it ourselves.

shiyu22 commented 3 years ago

Thanks @seo-jinBro to fix this problem.