Closed MichalBrzozowski91 closed 5 months ago
Thanks for the review :)
I added the main changes concerning division classes into Classifier
and Regressor
I did not implement the custom loss and optimizer:
I would also love to see the same basic tests for the Regressor classes.
Summary of issues we have discussed today on the call:
Classifier
andRegressor
BertClassifier
class as a base for bothpredict
method returning classes andpredict_scores
method returning probabilitiespredict
method_predict_logits
as a protected method that is used bypredict
/predict_scores
to get meaningful results