search

mim1q / ConvenientDecor

Apache License 2.0
2 stars 5 forks source link

Use Locale.ROOT for converting types to lowercase in PitchforkBlock. #13

Closed McModknower closed 2 months ago

McModknower commented 2 months ago

This prevents an issue faced by players with the turkish language, as an uppercase I is changed to a lowercase dotless ı in that locale, which is not a valid character for block property names.

Attached is a crash report of one of the players having that issue. For searchability here is the error message: Block{minecraft:air} has property: type with invalidly named value: straıght

crash-2024-06-22_19.54.02-client.txt

Edit: as a workaround players can add -Duser.language=en to their Java arguments.

mim1q commented 2 months ago

Hey! Sorry for taking so long with this. Thanks for bringing this issue to my attention

I fixed it the "proper" way now with 1211f0f. Gonna be releasing a bugfix update soon, but I want to take care of a few other minor issues before that