search

mimblewimble / grin-gui

GUI for Grin Node + Wallet
GNU General Public License v3.0
20 stars 21 forks source link

[Bug]: Transaction cancel fails #82

Open phyro opened 9 months ago

phyro commented 9 months ago

Describe the bug This is using CONTRACTS flow. Unable to cancel transaction in transaction history.

To Reproduce Steps to reproduce the behavior:

  1. Click Start and tick self-spend box
  2. Click Create
  3. Don't sign the transaction, just click cancel
  4. We have a new entry in tx log that can't be cancelled

Expected behavior I'd expect the cancel to work and delete the log.

Screenshots /

Desktop (please complete the following information):

Additional context

Here are the logs

20240119 16:31:08.149 DEBUG grin_gui::gui::element::wallet::operation::home - Cancel Tx: 204
20240119 16:31:08.149 DEBUG grin_gui::gui::element::wallet::operation::home - Interaction::WalletOperationHomeViewInteraction::CancelTx
20240119 16:31:08.149 DEBUG grin_wallet_libwallet::api_impl::owner_updater - Updating outputs from node
20240119 16:31:08.151 DEBUG grin_wallet_libwallet::internal::updater - Refreshing wallet outputs
20240119 16:31:08.166 TRACE grin_wallet_impls::node_clients::http - Output query chunk size is: 500
20240119 16:31:08.207 DEBUG grin_wallet_libwallet::api_impl::owner_updater - Updating transactions
20240119 16:31:08.218 WARN grin_wallet_libwallet::api_impl::owner - Attempted to update via kernel excess for transaction Some(9e99a3c0-a1ce-4ae7-8498-e61dff5edc5d), but kernel excess was not stored
20240119 16:31:08.218 WARN grin_wallet_libwallet::api_impl::owner - Attempted to update via kernel excess for transaction Some(1791a37b-a0f0-498f-8ead-84f63d397122), but kernel excess was not stored
20240119 16:31:08.220 DEBUG grin_wallet_libwallet::api_impl::owner_updater - Starting UTXO scan
20240119 16:31:08.220 WARN grin_wallet_libwallet::api_impl::owner_updater - Scanning - 0% complete
20240119 16:31:08.253 DEBUG grin_wallet_libwallet::api_impl::owner_updater - Checking 101 outputs, up to index 4276585. (Highest index: 4276585)
20240119 16:31:08.253 WARN grin_wallet_libwallet::api_impl::owner_updater - Scanning - 99% complete
20240119 16:31:08.263 DEBUG grin_wallet_libwallet::api_impl::owner_updater - Identified 0 wallet_outputs as belonging to this wallet
20240119 16:31:08.263 WARN grin_wallet_libwallet::api_impl::owner_updater - Scanning - 99% complete
20240119 16:31:08.268 WARN grin_wallet_libwallet::api_impl::owner_updater - Scanning Complete
20240119 16:31:08.281 ERROR grin_gui - Failed to Cancel Transaction
20240119 16:31:08.281 ERROR grin_gui - caused by: Transaction 204 cannot be cancelled
yeastplume commented 8 months ago

Turns out this is issue is actually in grin wallet, with self-spends being uncancellable. Will fix there shortly.

yeastplume commented 7 months ago

Should be fixed in alpha 5 if anyone wants to check

cekickafa commented 7 months ago

Desktop

Followed @phyro steps. I signed the transaction, just clicked cancel. The new entry in tx log, cancelled. Dissapperared from the log.