search

mimblewimble / grin-pm

Grin project management resources and docs
Apache License 2.0
75 stars 39 forks source link

Spending Log Update to Q1 2023 #429

Closed yeastplume closed 1 year ago

yeastplume commented 1 year ago
Anynomouss commented 1 year ago

Looks all good to me 👍. For clarity, all development maintenance payments = payment to @yeastplume correct?

yeastplume commented 1 year ago

Looks all good to me 👍. For clarity, all development maintenance payments = payment to @yeastplume correct?

Thank you for looking over it. I'm the only full-time developer on the project at the moment, I wish that were different.

Can you elaborate on "Accounting discrepancy discovered March 08 2021: most likely arisen due to the old way we were handling addresses and outputs prior to the consolidation." What was the old way, and what the new?

Apologies, but I have no idea. I've only just taken over PM duties and this entry was made several years ago at a time when I was away from the project. It's likely something to do with consolidating addresses into a single change address that we reuse to keep accounting and transparency simple.

phyro commented 1 year ago

I too am not sure what the discrepancy is about, just leaving here some links I found around it.

keybase://chat/grincoin#general/29671

lehnberg:

It took me a while and I almost went slightly mad but there's a small discrepancy happening sometime in Q4 2019 or earlier that caused numbers not to add up
details here, https://github.com/mimblewimble/grin-pm/pull/402
roughly USD 125 at the time
antioch has been paid, but I've not yet update the log for that I just recalled, so need to do that
and Q1 2021 report will be due in April

keybase://chat/grincoin#general/28722

lehnberg:

Please those of you around, please give this a thorough review:
https://github.com/mimblewimble/grin-pm/pull/402

This addresses our previous accounting issues  (https://github.com/mimblewimble/grin-pm/pull/362#issuecomment-770401894) where it was realized we were not acocunting for tx fees all this time... (facepalm)

Unfortunately I couldn't get the whole thing to reconcile properly, without adding a 0.01744541 BTC discrepancy in Q4 2019 ( ~ $125 at the time). 

Not sure what happened here really, we weren't making it easy to proper accounting before we reconciled all the outputs under the same pubkey. We're doing it better these days.